[SSSD] [PATCH] Fix initialization of multiple variables

Simo Sorce simo at redhat.com
Wed Mar 13 22:45:22 UTC 2013


On Tue, 2013-03-12 at 15:07 +0100, Michal Židek wrote:
> On 03/12/2013 03:03 PM, Ondrej Kos wrote:
> > On 03/12/2013 02:47 PM, Michal Židek wrote:
> >> On 03/12/2013 01:07 PM, Ondrej Kos wrote:
> >>
> >>> diff --git a/src/providers/krb5/krb5_renew_tgt.c
> >>> b/src/providers/krb5/krb5_renew_tgt.c
> >>> index
> >>> e8957484286b34781f66d5dc43efdf4a3dab4530..f593edb506b4e207f6cdc786bf144fd04ea7f51c
> >>>
> >>> 100644
> >>> --- a/src/providers/krb5/krb5_renew_tgt.c
> >>> +++ b/src/providers/krb5/krb5_renew_tgt.c
> >>> @@ -157,7 +157,7 @@ static errno_t renew_all_tgts(struct renew_tgt_ctx
> >>> *renew_tgt_ctx)
> >>>       time_t now;
> >>>       struct auth_data *auth_data;
> >>>       struct renew_data *renew_data;
> >>> -    struct tevent_timer *te;
> >>> +    struct tevent_timer *te = NULL;
> >>>
> >>>       ret = hash_entries(renew_tgt_ctx->tgt_table, &count, &entries);
> >>>       if (ret != HASH_SUCCESS) {
> >>
> >> Could you remove the te = NULL; on line 200 in this file. It is not
> >> needed if the variable is initialized.
> >>
> >> Michal
> >
> > Nice catch, new patch attached.
> >
> > Ondra
> >
> >
> 
> Ack.

Pushed to master

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list