[SSSD] [PATCH] krb5-utils-tests: remove invalid condition

Sumit Bose sbose at redhat.com
Wed Mar 13 11:48:57 UTC 2013


On Wed, Mar 13, 2013 at 12:32:05PM +0100, Pavel Březina wrote:

> From 78a1667c897d16ab7e08c49422160c2c5a64adf1 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
> Date: Wed, 13 Mar 2013 11:51:18 +0100
> Subject: [PATCH] krb5-utils-tests: remove invalid condition
> 
> This condition is invalid because different_realm is not set, when
> EINVAL is returned. It can make the test fail sometimes.
> ---
>  src/tests/krb5_utils-tests.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/tests/krb5_utils-tests.c b/src/tests/krb5_utils-tests.c
> index bc1890f0b5becf3f316eca31dfd20f30e25fa4f0..aa2f4ed4b8eb39c3aea8fdf53f27f12e096b9233 100644
> --- a/src/tests/krb5_utils-tests.c
> +++ b/src/tests/krb5_utils-tests.c
> @@ -700,8 +700,6 @@ START_TEST(test_compare_principal_realm)
>      ret = compare_principal_realm("userABC", "ABC", &different_realm);
>      fail_unless(ret == EINVAL, "Missing '@' does not cause EINVAL.");
>  
> -    fail_unless(different_realm == false, "Same realm but " \
> -                                          "different_realm is not false.");
>      ret = compare_principal_realm("user at ABC", "ABC", &different_realm);
>      fail_unless(ret == EOK, "Failure with same realm");
>      fail_unless(different_realm == false, "Same realm but " \
> -- 
> 1.7.11.7
> 

ACK

Thank you for catching this.

bye,
Sumit
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list