[SSSD] [PATCH] Removing unused header file providers.h

Simo Sorce simo at redhat.com
Tue Mar 12 13:01:44 UTC 2013


On Tue, 2013-03-12 at 12:13 +0100, Sumit Bose wrote:
> On Tue, Mar 12, 2013 at 10:57:38AM +0100, Lukas Slebodnik wrote:
> > Hi,
> > 
> > I found two header files, which are not included in any other file
> > src/providers/providers.h and src/sss_client/protos.h
> > First one is removed in attached patch and second one was commented
> > with "#if 0" more then four years ago. But I am not sure it should be
> > removed (is it documentation?), therefore is not removed in attached patch.
> > 
> > LS
> 
> I guess protos.h can be removed as well. Looks like it was used to
> track which nss-calls are still not implemented. But it is out of date,
> e.g. netgroups and services are already implemented and using
> src/sss_client/sss_nss.exports for this makes more sense.
> 
> Simo, do you see a reason to keep protos.h?

Unused code is broken code, feel free to remove.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list