[SSSD] [PATCH 1/2] Reuse sss_open_cloexec at other places in code.

Ondrej Kos okos at redhat.com
Mon Mar 11 14:26:48 UTC 2013


On 03/11/2013 11:42 AM, Lukas Slebodnik wrote:
> On (11/03/13 10:48), Ondrej Kos wrote:
>> On 03/11/2013 10:22 AM, Lukas Slebodnik wrote:
>>> diff --git a/src/util/util.h b/src/util/util.h
>>> index 8afb3bc964dfc7ea5debf8127b7c6bac08d11f42..2adc8cb4180ae802afee63d084c3d1d67f273862 100644
>>> --- a/src/util/util.h
>>> +++ b/src/util/util.h
>>> @@ -584,6 +584,9 @@ errno_t sssd_domain_init(TALLOC_CTX *mem_ctx,
>>>   /* from util_lock.c */
>>>   errno_t sss_br_lock_file(int fd, size_t start, size_t len,
>>>                            int num_tries, useconds_t wait);
>>> +/* from compact.c */
>>
>> if the file is renamed to io.c, please rewrite also this comment to
>> avoid confusion
>>
>>> +int sss_open_cloexec(const char *pathname, int flags, int *ret);
>>> +int sss_openat_cloexec(int dir_fd, const char *pathname, int flags, int *ret);
>>
>>
>> --
>> Ondrej Kos
>> Associate Software Engineer
>> Identity Management
>> Red Hat Czech
>>
>> phone: +420-532-294-558
>> cell:  +420-736-417-909
>> ext:   82-62558
>> loc:   1013 Brno 1 office
>> irc:   okos @ #sssd #brno
>
> Thank you for the notice, patches attached.
>

there are left unused variables after application of your patches, 
remove these and I'll ack them

src/providers/ldap/sdap_child_helpers.c: In function 'setup_child':
src/providers/ldap/sdap_child_helpers.c:456:14: warning: unused variable 
'v' [-Wunused-variable]

src/providers/krb5/krb5_init_shared.c: In function 'krb5_child_init':
src/providers/krb5/krb5_init_shared.c:33:14: warning: unused variable 
'v' [-Wunused-variable]

-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

phone: +420-532-294-558
cell:  +420-736-417-909
ext:   82-62558
loc:   1013 Brno 1 office
irc:   okos @ #sssd #brno



More information about the sssd-devel mailing list