[SSSD] [PATCH] Convert ldap_auth to new error codes

Simo Sorce simo at redhat.com
Sat Mar 9 23:15:48 UTC 2013


On Tue, 2013-03-05 at 18:57 +0100, Jakub Hrozek wrote:
> On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote:
> > It seems that at least some error codes are mishandled. When I attempt
> > to auth with a bad password, SSSD returns System Error. This is not what
> > we want, for some display managers (xdm and I thin even kdm) the System
> > Error retval would mean a popup is displayed to the user.
> > 
> > Auth, GSSAPI auth and offline auth works fine, though.
> 
> btw I'm still seeing these errors even with the patch to fix masking the
> new error codes.

I fixed a couple of places where the errors were improperly translated
or set.
Now ldap auth returns the proper pam error (7, Authentication Failure)
with a wrong password.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-common-error-facility-instead-of-sdap_result.patch
Type: text/x-patch
Size: 51290 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130309/92730e5e/attachment.bin>


More information about the sssd-devel mailing list