[SSSD] [PATCH] File descriptor leak in nss responder.

Michal Židek mzidek at redhat.com
Thu Mar 7 14:02:46 UTC 2013


On 03/07/2013 02:42 PM, Simo Sorce wrote:
> On Thu, 2013-03-07 at 13:44 +0100, Michal Židek wrote:
>> Ok :)
>> So I removed the unlink() from destructor (and the sss_mc_set_recycled
>> with it). I added new dret variable to catch return value from
>> unlink()
>> in the done: part of sss_mc_create_file(), so that we do not overwrite
>> the original error code.
>>
>> Also the mc_ctx->fd should be set to -1 if the file construction in
>> sss_mc_create_file (so that we do not try to close garbage file
>> descriptor in the destructor). So I added this too.
>>
>> New patches are attached.
>
> I still see the unlink in the destructor ...
>
> Simo.
>>

Sorry, I had uncommited change in git.

Here is the correct patch.

Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-File-descriptor-leak-in-nss-responder.patch
Type: text/x-patch
Size: 5566 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130307/5754a3b6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Debug-message-in-sss_mc_create_file.patch
Type: text/x-patch
Size: 1131 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130307/5754a3b6/attachment-0001.bin>


More information about the sssd-devel mailing list