Review Request 245: openlmi-networking [2/6] New model for creating connections

Jan Safranek reviewboard at gallagherhome.com
Mon Apr 22 13:58:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/245/#review277
-----------------------------------------------------------

Ship it!


There is no error checking in the code (strdup, malloc, ...)! The author agreed to add it later.

- Jan Safranek


On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/245/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 2:41 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> New model for creating connections
> 
> Now all network connections are created via LMI_CreateIPSetting method of
> LMI_IPNetworkConnectionCapabilities. Modifications are done using ModifyInstance
> method (will be part of subsequent commit) of the instances of
> IPAssignmentSettingData (and subclasses).
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof 3d82806e0b92a7fcba3b118f52f1f9144397173c 
>   src/LMI_IPConfigurationServiceProvider.c 7e18d9474164812900bbe2f4e5a8785d3706517c 
>   src/LMI_IPNetworkConnectionCapabilitiesProvider.c PRE-CREATION 
>   src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c PRE-CREATION 
>   src/network_nm.c c5426362030ffd8f5735043861580bb77ba87a7e 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130422/c0b09703/attachment.html>


More information about the openlmi-devel mailing list