Review Request 186: service: added dbus based service provider [1/1] service: added dbus based service provider
Roman Rakus
reviewboard at gallagherhome.com
Mon Apr 15 19:41:40 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/186/#review218
-----------------------------------------------------------
src/service-dbus/LMI_ServiceProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment122>
Looking at Service_Find_All() definition it can return NULL - check it here.
src/service-dbus/LMI_ServiceProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment123>
Use LMI_Service_ClassName from LMI_Service.h
src/service-dbus/LMI_ServiceProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment124>
Again, use LMI_Service_ClassName
src/service-dbus/util/serviceutil.h
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment127>
Function names does not follow our coding conventions - name of methods / variables use snake_case_with_underscores
src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment125>
Missing checks for malloc()s
src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment126>
What are these magic numbers? Maybe add a comment.
src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/186/#comment128>
Looks like missing free for those strdup()s.
- Roman Rakus
On April 11, 2013, 3:23 p.m., Vitezslav Crhonek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/186/
> -----------------------------------------------------------
>
> (Updated April 11, 2013, 3:23 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> service: added dbus based service provider
>
>
> Diffs
> -----
>
> README 7e17e458ef4699a62ec933a6d4a51f35588f97e1
> src/CMakeLists.txt 73189110171562bdcbaf56faff7d2d07b325a076
> src/service-dbus/CMakeLists.txt PRE-CREATION
> src/service-dbus/LMI_ServiceProvider.c PRE-CREATION
> src/service-dbus/util/serviceutil.h PRE-CREATION
> src/service-dbus/util/serviceutil.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/186/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vitezslav Crhonek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130415/d80db292/attachment-0001.html>
More information about the openlmi-devel
mailing list