Review Request 121: openlmi-software [5/7] added support for indications to software providers

Jan Safranek reviewboard at gallagherhome.com
Wed Apr 10 07:07:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/121/#review141
-----------------------------------------------------------



mof/LMI_SoftwareIndicationFilters.mof
<http://reviewboard-openlmi.rhcloud.com/r/121/#comment100>

    (discussed offline, just for the record) please make sure these queries works in SFCB.



src/python/openlmi/common/JobManager.py
<http://reviewboard-openlmi.rhcloud.com/r/121/#comment101>

    Whole Job class looks very similar to Job in openlmi-storage, could you please push whole patchset to some git repo (fedorapeople, github, ...) so I can compare it?


- Jan Safranek


On April 8, 2013, 12:07 p.m., Michal Minar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/121/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 12:07 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> added support for indications to software providers
> 
> Only static indication filters listed in
> mof/LMI_SoftwareIndicationFilters.mof are supported. They should be
> installed at rpm package installation, so user can use them for
> subscriptions.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Software.mof 824659ef1770db91f1c1ee2874cf90f4829d5756 
>   mof/LMI_Software.reg d8e05ee34b259caae8492ad5003fff6ada499db4 
>   mof/LMI_SoftwareIndicationFilters.mof PRE-CREATION 
>   src/python/openlmi/common/JobManager.py PRE-CREATION 
>   src/software/openlmi/software/cimom_entry.py 4aa1d44b24b811197f8e316084ea7fdf3774857a 
>   src/software/openlmi/software/yumdb/__init__.py d64c0f43a6d1aeabd31eca193becff76f6d6e4de 
>   src/software/openlmi/software/yumdb/errors.py 101c40ba507e6557bd515d75dabc3d920fc105ec 
>   src/software/openlmi/software/yumdb/jobmanager.py 872e81fecf030743d89d41d0436a2cb5cd1fb878 
>   src/software/openlmi/software/yumdb/process.py 0b0c4c17521595a414c487cc1931266c5584e690 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Minar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130410/7fbee25e/attachment-0001.html>


More information about the openlmi-devel mailing list