[PATCH conductor 10/13] set @provider_account in provider_accounts_controller:destroy (currently not set)
Scott Seago
sseago at redhat.com
Fri May 18 03:14:38 UTC 2012
On 05/17/2012 09:40 AM, Mo Morsi wrote:
> ---
> .../controllers/provider_accounts_controller.rb | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/app/controllers/provider_accounts_controller.rb b/src/app/controllers/provider_accounts_controller.rb
> index bf48af3..aaaaf86 100644
> --- a/src/app/controllers/provider_accounts_controller.rb
> +++ b/src/app/controllers/provider_accounts_controller.rb
> @@ -139,6 +139,7 @@ class ProviderAccountsController< ApplicationController
> end
>
> def destroy
> + @provider_account = Provider.find(params[:id])
Better use ProviderAccount.find instead of Provider.find or you'll be
checking permissions on the wrong object.
> require_privilege(Privilege::MODIFY, @provider_account)
> @provider = Provider.find(params[:provider_id])
Also, once you have @provider_account, you can just call .destroy on it
rather than the below (destroying by ID)
> if ProviderAccount.destroy(params[:id])
Scott
More information about the aeolus-devel
mailing list