aeolus security - round 1 (rev 3)

Mo Morsi mmorsi at redhat.com
Thu May 10 07:53:43 UTC 2012


On 05/09/2012 07:56 PM, Jozef Zigmund wrote:
> On Wednesday 09 May 2012 14:55:56 Mo Morsi wrote:
>> Rebased the security patchset against the current HEAD
> Sry, for me it cannot be applied because of trailing whitespace .. 
>
> Applying: validate class names which constantize is called on correspond to db 
> table names
> /home/jzigmund/deltacloud/aggregator/.git/rebase-apply/patch:18: trailing 
> whitespace.
>     end 
> warning: 1 line adds whitespace errors.
> src/app/controllers/permissions_controller.rb:199: trailing whitespace.
> +    end
>
> seems that you dont have git hook to check trailing whitespace on 
> commit/formatting patch.

Hrm these should just be warnings, the patch should still apply fine and
should be testable.

Will take care of removing the whitespace on the next revision and/or
before pushing the patchset if it is ack'd.

  -Mo



More information about the aeolus-devel mailing list