[PATCH conductor 01/11] Moved "I am an authorized user" step definition from pool_step.rb to user_step.rb

Petr Blaho pblaho at redhat.com
Wed May 9 13:27:39 UTC 2012


On Wednesday, May 09, 2012 08:45:40 AM Jason Guiditta wrote:
> On 08/05/12 19:45 +0200, pblaho at redhat.com wrote:
> >From: Petr Blaho <pblaho at redhat.com>
> >
> >---
> > src/features/step_definitions/user_steps.rb |    5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> >diff --git a/src/features/step_definitions/user_steps.rb b/src/features/step_definitions/user_steps.rb
> >index 3a88cb6..292fa94 100644
> >--- a/src/features/step_definitions/user_steps.rb
> >+++ b/src/features/step_definitions/user_steps.rb
> >@@ -19,6 +19,11 @@ Given /^there is a user "([^"]*)"$/ do |name|
> >   end
> > end
> >
> >+Given /^I am an authorised user$/ do
> >+  @admin_permission = FactoryGirl.create :admin_permission
> >+  @user = @admin_permission.user
> >+end
> >+
> 
> Perhaps you need a rebase?  I just looked at my checkout and this has
> already been moved to features/step_definitions/authentication.rb.
> Also this patch seems to only add, not move.  We should make sure this
> step exists in one and one one place (imo, authentication makes the
> most sense as that place).

Yes, you are right...
I have a commit prepared to resolve it.

> 
> -j
> > Given /^there are (\d+) users$/ do |number|
> >   User.count.should == number.to_i
> > end
> 
-- 

With regards
Petr Blaho



More information about the aeolus-devel mailing list