[PATCH conductor 2/4] properly quote strings

Mo Morsi mmorsi at redhat.com
Thu May 3 12:04:27 UTC 2012


On 05/03/2012 11:47 AM, Jan Provaznik wrote:
> On 05/02/2012 03:48 PM, Mo Morsi wrote:
>> ---
>>   src/config/locales/de.yml    |   12 ++++++------
>>   src/config/locales/en.yml    |    6 +++---
>>   src/config/locales/fr.yml    |    4 ++--
>>   src/config/locales/it.yml    |    4 ++--
>>   src/config/locales/pt-BR.yml |    2 +-
>>   5 files changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/src/config/locales/de.yml b/src/config/locales/de.yml
>> index 902480f..2be3fcb 100644
>> --- a/src/config/locales/de.yml
>> +++ b/src/config/locales/de.yml
>> @@ -260,7 +260,7 @@ de:
>>         no_catalog_selected: "Kein Katalog ausgewählt"
>>       new_from_image:
>>         catalog_entry_name: "%{name}"
>> -      description: "Markup- und Image-Referenzen in \%{name}\ wurden
>> erfolgreich überprüft. Sie können das Image nun speichern und eine
>> Deployable erstellen."
>> +      description: "Markup- und Image-Referenzen in \"%{name}\"
>> wurden erfolgreich überprüft. Sie können das Image nun speichern und
>> eine Deployable erstellen."
>
> Now when switching to 'de' on F16/ruby 1.8, I'm getting this error:
> missing interpolation argument in "Markup- und Image-Referenzen in
> \"%{name}\" wurden erfolgreich überprüft. Sie können das Image nun
> speichern und eine Deployable erstellen." ({:environment=>"default"}
> given)
>

How are you producing this error? I enabled the 'de' localization in
config/application.rb, and started the rails server. The application
came up fine and I was able to login.

In any case the problem is if we don't change the localizations in this
way, we get yaml parsing errors when running rake tasks on F17.

See mtaylor's feedback to my original patchset [1]. As soon as this
patch is applied the errors that were were getting when running rake
db:migrate go away.

Just talked to Jozef and he mentioned that we can remove the backslashes
alltogether which should fix this issue. Just sent an updated patch
doing just this.

Thanks for testing it out,
  -Mo

[1] https://fedorahosted.org/pipermail/aeolus-devel/2012-April/010051.html




More information about the aeolus-devel mailing list