[PATCH conductor] BZ801825: detect_locale handles a wider range of strings

Matt Wagner matt.wagner at redhat.com
Wed Mar 14 13:48:58 UTC 2012


On Wed, Mar 14, 2012 at 02:26:50PM +0100, Imre Farkas wrote:
> On 03/14/2012 01:53 PM, Tomas Sedovic wrote:
> >
> >ACK though I'm a bit worried: that's an awful lot of code for something
> >that should be a standard HTTP feature: parsing and sorting the -type
> >weighted arguments.
> >
> >Doesn't Rails or Rack have something that already does this in a
> >(hopefully) cleaner and robust way?
> 
> Good point but unfortunately there is no builtin functionality for
> this in Rails afaik. The Rails Guides [1] can only recommend some
> gems which cannot be found in Fedora or RHEL repos.
> 
> Thanks for the review!
> 
> [1] http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the-client-supplied-information.

Yes, this was surprising to me when we first implemented this: Rails
indeed has no native support for doing this. Furthermore, the gems I
looked at weren't very impressive.

-- Matt



More information about the aeolus-devel mailing list