[PATCH conductor] BZ 800849 - CREATE_FAILED instances will not be marked as vanished

Matt Wagner matt.wagner at redhat.com
Wed Mar 7 22:43:04 UTC 2012


On Wed, Mar 07, 2012 at 05:35:29PM -0500, Matt Wagner wrote:
> Since they were never created on the backend provider, it doesn't
> make a lot of sense to mark them as "vanished." It's also a bad user
> experience. Instead, if an instance fails to get created, leave it
> in that state.
> 
> This resolves https://bugzilla.redhat.com/show_bug.cgi?id=800849
> and likely https://bugzilla.redhat.com/show_bug.cgi?id=800837 too.
> ---

I forgot --compose on this. The commit message is helpful, but a little
more detail... This largely fixes the issue described in #800849 in
which instances which failed to launch at all (STATE_CREATE_FAILED)
would get picked up dbomatic as "vanished" and removed.

Although technically correct on some level (they weren't present on the
back-end provider), this was fairly misleading: they didn't mysteriously
vanish from the backend provider -- they never made it to the backend
provider! So instead, if an instance is in STATE_CREATE_FAILED, we
should lave it in that state.

While changing that, I also tweaked dbomatic to not update instances in
VANISHED state to VANISHED state, since this was pointless for obvious
reasons.

I believe it will incidentally fix 800837 in some cases, but thinking
about it a little more, I would like to explicitly change the styling to
consider "vanished" images to have the "failure" class applied as well.
So only evaluate this patch in the context of #800849.

-- Matt



More information about the aeolus-devel mailing list