[PATCH conductor] BZ790026-Deleting a provider with running instances does not show any message

Jozef Zigmund jzigmund at redhat.com
Thu Mar 1 16:35:53 UTC 2012


On Tuesday 28 February 2012 10:06:34 Tomáš Hrčka wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=790026
> ---
>  src/app/controllers/providers_controller.rb       |    3 ++-
>  src/app/views/layouts/_new_notification.html.haml |    2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/app/controllers/providers_controller.rb
> b/src/app/controllers/providers_controller.rb index 0819b99..f57c243 100644
> --- a/src/app/controllers/providers_controller.rb
> +++ b/src/app/controllers/providers_controller.rb
> @@ -32,7 +32,8 @@ class ProvidersController < ApplicationController
>      respond_to do |format|
>        format.html do
>          if @providers.present?
> -          redirect_to edit_provider_path(@provider), :notice =>
> flash[:notice], :error => flash[:error] +          flash.keep
> +          redirect_to edit_provider_path(@provider)
>          else
>            render :action => :index
>          end
> diff --git a/src/app/views/layouts/_new_notification.html.haml
> b/src/app/views/layouts/_new_notification.html.haml index 54ed324..e7a38b4
> 100644
> --- a/src/app/views/layouts/_new_notification.html.haml
> +++ b/src/app/views/layouts/_new_notification.html.haml
> @@ -62,7 +62,7 @@
>                      %li= [k, v.present? ? ": #{v}" : '']
>                  -else
>                    -flash[:error][:failures].each do |k, v|
> -                    %li= [v]
> +                    %li= [k,v]

In part ELSE we dont need to use EACH, because it means that flash[:error]
[:failures] contains only one message.
>                -else
>                  -flash[:error].each do |e|
>                    %li= e

ACK with one inline note.



More information about the aeolus-devel mailing list