[PATCH] BZ 811639 - during permission multi_update, change error message if no modifications needed

Scott Seago sseago at redhat.com
Thu Aug 16 20:35:36 UTC 2012


On 08/16/2012 04:13 PM, Tzu-Mainn Chen wrote:
> ---
>   src/app/controllers/permissions_controller.rb |    2 +-
>   src/config/locales/en.yml                     |    1 +
>   2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/app/controllers/permissions_controller.rb b/src/app/controllers/permissions_controller.rb
> index cd80e02..33c2a7e 100644
> --- a/src/app/controllers/permissions_controller.rb
> +++ b/src/app/controllers/permissions_controller.rb
> @@ -114,7 +114,7 @@ class PermissionsController<  ApplicationController
>         flash[:error] = t('permissions.flash.error.not_add', :list =>  not_modified.to_sentence)
>       end
>       if modified.empty? and not_modified.empty?
> -      flash[:error] = t("permissions.flash.error.no_users_selected")
> +      flash[:notice] = t("permissions.flash.notice.no_change")
>       end
>       respond_to do |format|
>         format.html { redirect_to @return_path }
> diff --git a/src/config/locales/en.yml b/src/config/locales/en.yml
> index 88c16e6..dc38241 100644
> --- a/src/config/locales/en.yml
> +++ b/src/config/locales/en.yml
> @@ -1401,6 +1401,7 @@ en:
>           modified: "Successfully modified the following User Roles: %{list}"
>           deleted: "Deleted the following Permission Grants: %{list}"
>           added: "Added the following User Roles: %{list}"
> +        no_change: "All User Roles already set; no changes needed"
>         error:
>           not_add: "Could not add these User Roles: %{list}"
>           no_users_selected: No users selected
ACK and pushed




More information about the aeolus-devel mailing list