[PATCH conductor] Various string tweaks

Matt Wagner matt.wagner at redhat.com
Thu Aug 16 15:40:43 UTC 2012


On Wed, Aug 15, 2012 at 05:28:43PM -0400, Matt Wagner wrote:
> 
> I haven't gone line-by-line yet, but I have two nits inline above. You
> mentioned that you're going to send a follow-up patch with some
> additional fixes, so we can just fold them into that if you want and go
> with this one.
> 
> Beyond the two nits, there's one big thing -- this breaks a whole bunch
> of tests that (badly!) check for various strings which have now changed.
> In the interim I'm fixing them up to check for the new strings, but
> that's kind of a Band-Aid to the real problem. (Actually, it's more like
> replacing the Band-Aid when the old one stops working.) But I don't want
> fixing our tests to get in the way of cleaning up our strings, so I
> think that's the right thing for now.
> 
> I will send out the test fixes I have tomorrow morning. I've got to run
> and don't have them finished yet.

D'oh! One other thing: this deletes the provider_priority_groups section
that was added the other day. Probably a merge issue.



More information about the aeolus-devel mailing list