Using pull requests on Aeolus

Matt Wagner matt.wagner at redhat.com
Tue Aug 7 13:43:15 UTC 2012


On Tue, Aug 07, 2012 at 01:28:26PM +0200, Tomas Sedovic wrote:
> 
> It's probably worth noting that at least three Aeolus-related
> projects do use the GitHub pull-request model: Image Factory[1],
> Oz[2] and Image Management Engine[3].

My understanding is that the Incubator projects use them as well.

> While we're at it, what about proper git (as oposed to GitHub) pull
> requests? That is, you have a publicly readable repo (on GitHub or
> elsewhere) and when you want someone to review and merge your changes
> you send them the link to the repo and the branch name to pull.
> 
> If I remember correctly, that was the modus operandi for which git
> was invented.
> 
> It provides a nice balance between splitting the conversation about
> the patches (github and mailing list) whilst still being reasonably
> simple to use (it adds about one additional step on each side
> compared to GitHub pull requests).

I think you're right about that being a common/intended workflow. But
honestly, one of the main things I liked about doing GitHub pull
requests is that you get a nice web UI listing all of the outstanding
ones.

What made me really want to start using pull requests was the
realization that there are a ton of patches outstanding, but that I have
no idea what they are, or if someone else is already reviewing them.

-- Matt



More information about the aeolus-devel mailing list