[PATCH configure] BZ#740089: fix wording in interactive installer

John Eckersberg jeckersb at redhat.com
Tue Dec 20 17:56:58 UTC 2011


On Thu,  8 Dec 2011 07:43:44 -0500, Mo Morsi <mmorsi at redhat.com> wrote:
> ---
>  recipes/aeolus/cli.rb |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/aeolus/cli.rb b/recipes/aeolus/cli.rb
> index cd3d0dd..a685d18 100644
> --- a/recipes/aeolus/cli.rb
> +++ b/recipes/aeolus/cli.rb
> @@ -33,11 +33,13 @@ NODE_YAML='/etc/aeolus-configure/nodes/custom'
>  IMAGE_TEMPLATE='/etc/aeolus-configure/custom_template.tdl'
>  PROFILE_RECIPE='/usr/share/aeolus-configure/modules/aeolus/manifests/profiles/custom.pp'
>  
> +first = true
>  installed_component = nil
>  install_components  = ["- aeolus::conductor"]
>  while ![:None, :All].include?(installed_component)
>    clear_screen
> -  say "Select Aeolus Components to Install"
> +  say "Select #{first ? "First" : "Next" } Aeolus Component to Install"
> +  first = false
>    installed_component =
>      choose do |menu|
>        menu.prompt = "Install Aeolus Component: "
> -- 
> 1.7.6.4
> 

Verified as functional.  However, it was not obvious to me that
selecting "None" would break out of the loop and proceed with what had
been previously selected.  I thought that I could say...

1. Select "Image Factory"
2. Select "Image Warehouse"
3. Select "None"

And the end result would be a no-op.  Perhaps "None" should be more
explicit like "Finished selecting components" ?



More information about the aeolus-devel mailing list