imagefactory initscript and .spec changes

James Laska jlaska at redhat.com
Thu Dec 15 16:34:07 UTC 2011


Greetings,

> GIT: [PATCH 1/3] Add /etc/sysconfig/imagefactory support

While debugging/patching imagefactory with calfonso earlier this week, we both
noticed that the default 'imagefactory' command-line options are not
accessible.  In order to adjust the default command-line options, it is
required to modify the initscript directly.  To resolve this, I've created
/etc/sysconfig/imagefactory to house the initscript configuration that is
sourced from the initscript.  The file allows adminstrators to override common
imagefactory command-line options without modifying "code" directly.

> GIT: [PATCH 2/3] Add logrotate support

While discussing this patc, calfonso pointed out that imagefactory would
eventually need logrotation support.  This patch adds weekly log rotation.

> GIT: [PATCH 3/3] Use install macro and adjust config perms

Lastly, I noticed the config file permissions were 664.  This patch adjusts the
permissions appropriately, and uses the built-in %{__install} rpm macro.

I have rpm packaged and tested these changes locally, and things appear to work
by design.  Comments/complaints/suggestions encouraged!

Thanks,
James



More information about the aeolus-devel mailing list