Implement SSL vhost support in ssh tunneling.
Chris Alfonso
calfonso at redhat.com
Wed Dec 14 14:38:04 UTC 2011
On 14/12/11 09:35 -0500, Jason Guiditta wrote:
>On 14/12/11 08:11 -0500, Chris Alfonso wrote:
>>This patch creates a forwarding tunnel to the repository hosts. A
>>temporary host entry is added as an alias in the guest /etc/hosts.
>>When the tunnel is finished being used, the alias is removed and any
>>persisted repositories are reverted to their original base urls.
>>---
>>oz/RedHat.py | 55 +++++++++++++++++++++++++++++++++++++++++--------------
>>1 files changed, 41 insertions(+), 14 deletions(-)
>>
>>diff --git a/oz/RedHat.py b/oz/RedHat.py
>>index 48a4483..ebc2ee5 100644
>>--- a/oz/RedHat.py
>>+++ b/oz/RedHat.py
>>@@ -868,7 +868,6 @@ class RedHatCDYumGuest(RedHatCDGuest):
>> """
>> # this is the path to the metadata XML
>> full_url = repo_url + "/repodata/repomd.xml"
>>-
>> # first, check if we can access it from the host
>> self.data = ''
>> def _writefunc(buf):
>>@@ -877,37 +876,40 @@ class RedHatCDYumGuest(RedHatCDGuest):
>> """
>> self.data += buf
>>
>>- c = pycurl.Curl()
>>- c.setopt(c.URL, full_url)
>>- c.setopt(c.CONNECTTIMEOUT, 5)
>>- c.setopt(c.WRITEFUNCTION, _writefunc)
>>+ crl = pycurl.Curl()
>>+ crl.setopt(crl.URL, full_url)
>>+ crl.setopt(crl.CONNECTTIMEOUT, 5)
>>+ crl.setopt(crl.WRITEFUNCTION, _writefunc)
>
>Just a general comment, not a review of the patch as a whole. It
>makes it much harder for the reviewer to tell what has changed that is
>of importance when changes like the above are introduced as well. I
>agree a more descriptive variable name makes the code easier to
>understand, but the change would be better introduced in a separate
>patch, imo. That would make both patches more focused as well as
>easier to review.
Yeah, I thought about having a separate patch that removes the conflict between pdb and a variable name, but it seemed like it might be too much of a nit. I can do either though if it bothers too much.
>
>-j
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/aeolus-devel/attachments/20111214/25f34534/attachment.sig>
More information about the aeolus-devel
mailing list