[PATCH conductor] Fixing launch button on Deployables#show

Jirka Tomasek jtomasek at redhat.com
Fri Dec 9 15:49:05 UTC 2011


On 12/09/2011 03:41 PM, ifarkas at redhat.com wrote:
> From: Imre Farkas<ifarkas at redhat.com>
>
> https://bugzilla.redhat.com/show_bug.cgi?id=759044
> ---
>   src/app/stylesheets/custom.scss          |   14 ++++++++++++++
>   src/app/views/deployables/show.html.haml |    2 +-
>   2 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/src/app/stylesheets/custom.scss b/src/app/stylesheets/custom.scss
> index f3ce3bc..2e0f592 100644
> --- a/src/app/stylesheets/custom.scss
> +++ b/src/app/stylesheets/custom.scss
> @@ -100,6 +100,20 @@
>     overflow: hidden;
>   }
>
> +#obj_actions.button-container{
> +  #launch_deployment_button {
> +    margin-left: 20px;
> +    background: url(../../images/launch-button.png) no-repeat center;
> +    background-size: cover; -webkit-background-size: cover; -moz-background-size: cover;
> +    width: 73px;
> +    height: 27px;
> +    display: inline-block;
> +
> +    // Hide the text visually but keep it available for screen readers and such
> +    text-indent: -3000px;
> +  }
> +}
> +
>   .pool_details {
>     color: #333;
>     text-decoration: none;
> diff --git a/src/app/views/deployables/show.html.haml b/src/app/views/deployables/show.html.haml
> index f89ac19..be21515 100644
> --- a/src/app/views/deployables/show.html.haml
> +++ b/src/app/views/deployables/show.html.haml
> @@ -6,7 +6,7 @@
>         = button_to t('catalog_entries.show.delete'), catalog_deployable_path(@catalog, @deployable), :method =>  'delete', :confirm =>  "#{t'catalog_entries.show.confirm_delete'}", :class =>  'button danger', :id =>  'delete'
>         = link_to t('catalog_entries.show.edit'), edit_catalog_deployable_path(@catalog, @deployable), :class =>  'button', :id =>  'edit_button'
>
> -    = link_to t('deployments.overview.launch'), launch_new_deployments_path(:deployable_id =>  @deployable.id, :pool_id =>  @catalog.pool), :id =>  :launch_deployment
> +    = link_to t('deployments.overview.launch'), launch_new_deployments_path(:deployable_id =>  @deployable.id, :pool_id =>  @catalog.pool), :id =>  :launch_deployment_button
>
>   %section.admin-content-section
>     %header
NACK, the  fixed Launch button is implemented In patch I already send 
(although be resending) and the button is needed to be done by css, the 
background image you used is wrong. The text has to be translatable, so 
the button has got to have variable width.

Please check Redmine before you start working on some patch to avoid 
duplicating work.

Jirka



More information about the aeolus-devel mailing list