[PATCH conductor 0/1] Clean up Permission flash messages

Tomas Sedovic tsedovic at redhat.com
Mon Dec 5 13:37:17 UTC 2011


On 11/29/2011 11:37 PM, Matt Wagner wrote:
> In reviewing Scott's patch, I included a nit talking about how the flash messages (for both success and errors) were oddly-worded. Scott's patch didn't actually introduce them, so I just fixed them.
>
> It'd be great if someone who was an I18n master would look this over to make sure I'm not doing anything too unorthodox. I think this patch should have two benefits:
> 1.) The messages sound more human, at least to me.

For what it's worth from a non-native speaker, they sound better to me 
as well.

> 2.) We no longer concatenate strings outside of the data dictionary, so they should be more I18n-friendly.

This is exactly what we should be doing everywhere. I think the 
reviewers need to be more strict with what they allow i18n-wise. I've 
been guilty of letting this go as well.

>
> This patch was fixing a nit of mine and isn't an essential part of the sprint, so don't go too out of your way.
>
> -- Matt

ACK, thanks for doing this.

Thomas
-- 
No trees were killed to send this message, but a large number of 
electrons were terribly inconvenienced.



More information about the aeolus-devel mailing list