[PATCH conductor] Add images from Factory to API::ImagesController#index output

Matt Wagner matt.wagner at redhat.com
Thu Dec 1 19:28:04 UTC 2011


On Thu, Dec 01, 2011 at 05:43:00PM +0100, pblaho at redhat.com wrote:
> From: Petr Blaho <pblaho at redhat.com>
> 
> https://www.aeolusproject.org/redmine/issues/2497
> ---
>  src/app/controllers/api/images_controller.rb       |   27 ++++-
>  src/app/views/api/images/_image.xml.haml           |    2 +-
>  src/spec/controllers/api/images_controller_spec.rb |  116 +++++++++++++++++---
>  3 files changed, 122 insertions(+), 23 deletions(-)

I don't believe this is necessarily. It causes duplicates to show up for
me. I kicked off a RHEVM build (since EC2 and Mock complete essentially
instantly), and then tried this patch -- the new build showed up twice
in the list, with one occurrence in "BUILDING" and the other in
"COMPLETE" state. Same UUIDs for the image and the build both times.

After poking around and speaking with the Factory folks, it seems that
they create the image and build in Warehouse once Factory starts a
build, which would explain the duplication. (It was further explained
that the target image is created in Warehouse after the build completes,
and the provider image is created after the push finishes.)

-- Matt



More information about the aeolus-devel mailing list