[PATCH conductor 1/3] format_value is more cautious with calling .split

Matt Wagner mwaggy at gmail.com
Thu Dec 1 14:43:24 UTC 2011


On Thu, Dec 1, 2011 at 9:36 AM, Jason Guiditta <jguiditt at redhat.com> wrote:
> ACK to this one, I hit a similar issue just yesterday and didn't get
> around to correcting it yet.  I suspect your others are fine, so feel
> free to push them too, I just dont have the full setup to properly
> test them right now myself.  My only concern is when tests get
> commented out, they may get forgotten rather than fixed.

I share your general hesitation towards commenting-out failing tests,
but in this case, it's a test that I added the other day and I
strongly suspect it never really worked, but it wasn't failing
immediately because it was testing code that was never really being
exercised.

I'll go ahead and push the changes now, and leave you to push your
patch after rebasing.

-- Matt



More information about the aeolus-devel mailing list