[PATCH conductor 1/3] format_value is more cautious with calling .split
Matt Wagner
matt.wagner at redhat.com
Thu Dec 1 00:05:26 UTC 2011
On Wed, Nov 30, 2011 at 07:02:55PM -0500, Matt Wagner wrote:
> ---
> src/lib/aeolus/event/converter.rb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/aeolus/event/converter.rb b/src/lib/aeolus/event/converter.rb
> index b12d3b5..e082bd9 100644
> --- a/src/lib/aeolus/event/converter.rb
> +++ b/src/lib/aeolus/event/converter.rb
> @@ -30,10 +30,10 @@ module Aeolus
> def format_value(val)
> if val.nil?
> val = ""
> - elsif val.split.size > 1
> + elsif val.respond_to?(:split) && val.split.size > 1
> val = "\"#{val}\""
> end
> - return val
> + return val.to_s
> end
> end
> end
> --
> 1.7.6.4
I realized I never explained this. format_value was failing for Fixnum
and DateTime (or something similar) values because those classes don't
respond to .split.
More information about the aeolus-devel
mailing list