On 11. 02. 21 17:36, Dan Radez wrote:
On 2/2/21 12:09 PM, Miro Hrončok wrote:
> Hello Pythonistas.
>
> When we updated pytest to 5, I've introduced python-pytest4 compatibility
> package to ease the transition. We are now on pytest 6.2 and python-pytest4
> still exists.
>
> However, pytest 4 has problems on Python 3.10 and I lack the enthusiasm to
> backport the fixes from 6.2 to 4. The most recent issue proved to be nontrivial:
>
>
https://bugzilla.redhat.com/show_bug.cgi?id=1914847
>
>
> The only Fedora package pulling in pytest4 is python-pytest-relaxed, which
> Requires pytest < 5.
>
> - python-invoke and python-paramiko BuildRequire python3-pytest-relaxed
> - python-jsonmodels and python-paramiko BuildRequire python3-invoke
> - many packages (Build)Require python3-paramiko
>
>
> Ideas:
>
>
> 1) Add support of recent pytest to python-pytest-relaxed [ideal]
>
> Issue:
https://github.com/bitprophet/pytest-relaxed/issues/12
>
> Volunteers?
>
bitprophet seems to be willing to make this happen, Running the tests on py39
doesn't go well.
Not against keeping it, but seems it may be easier to prune it out if it becomes
unused and is so out of date.
>
> 2) Retire python-pytest4 and introduce python-pytest5
>
> pytest-relaxed seem to work with pytest5 witch some patches that are available.
> However, this is not a long term solution, so I'd rather not spend my time on
it.
>
>
> 3) Retire python-pytest4 and python-pytest-relaxed
>
> This requires disabling tests in invoke and slightly patching tests of
> paramiko. Once pytest-relaxed supports recent pytest, we can reintroduce it.
This patch in paramiko would remove the pytest-relaxed dependency. Then we could
remove both?
https://github.com/paramiko/paramiko/pull/1665/
May be least path of resistance to patch out pytest-relaxed like this. Then we
get all the paramiko tests to run and retire pytest4?
Yes, but we would also need to disable tests of python-invoke entirely, because
patching them out is not as simple as from paramiko.
> 4) Somebody else than me takes care of pytest4 and fixes it for
Python 3.10
>
> This requires long term involvement, not one time effort.
>
> Volunteers?
>
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok